Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): typo with default config #1493

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix(server): typo with default config #1493

merged 1 commit into from
Jan 3, 2024

Conversation

ellie
Copy link
Member

@ellie ellie commented Jan 3, 2024

Without TLS config, the server fails to load defaults. Until this is released, add this to your server config

[tls]
enable = false
cert_path = ""
pkey_path = ""

Without TLS config, the server fails to load defaults. Until this is
released, add this to your server config

```
[tls]
enable = false
cert_path = ""
pkey_path = ""
```
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 1:28pm

@ellie ellie merged commit 198b4e2 into main Jan 3, 2024
10 checks passed
@ellie ellie deleted the ellie/fix-tls branch January 3, 2024 13:30
buroa added a commit to buroa/k8s-gitops that referenced this pull request Jan 3, 2024
@buroa
Copy link

buroa commented Jan 3, 2024

Hey @ellie can we cut a new release with the fix? :)

@ellie
Copy link
Member Author

ellie commented Jan 3, 2024

I've put the new config in the release notes - happy to cut a release if it's really required

If you're automating this, you may be interested in the chart here: https://github.com/atuinsh/helm-charts

@buroa
Copy link

buroa commented Jan 3, 2024

I've put the new config in the release notes - happy to cut a release if it's really required

If you're automating this, you may be interested in the chart here: https://github.com/atuinsh/helm-charts

It's definitely not required, but it would be valuable for those that use a standard app-template: https://github.com/bjw-s/helm-charts. Almost all of my standalone apps use this template, which looks like the following: https://github.com/buroa/k8s-gitops/blob/master/kubernetes/apps/home/atuin/app/helmrelease.yaml. Thank you :-)

@onedr0p
Copy link

onedr0p commented Jan 3, 2024

Commenting here just to mention the env var fix would be setting ATUIN_TLS__ENABLE to false.

@ellie
Copy link
Member Author

ellie commented Jan 3, 2024

I'll cut a patch in a bit

@ellie
Copy link
Member Author

ellie commented Jan 3, 2024

Will be out shortly: #1495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants