fix(enter_accept): clear old cmd snippet #1350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #1341 and #1342. This clears the prompt of any command snippet the user entered before opening the atuin history search.
Both prompts still have issues with how the fake command looks after we've run it. Bash overwrite the whole prompt line with the command (See #1342), and I wasn't able to figure out how to clear the pre-existing cmd snippet from fish.
For the fish problem, as an example if you type
ech
, then hit ctrl+r and selectecho here
it will appear like this:I'm not sure how solid these fixes actually are, both shell's will cause a bit of confusion for users but I think it's the best we can do at the moment 🤷