Allow sending messages directly from ISR #881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w41/allow-sending-messages-from-isr
branch
2 times, most recently
from
4affd01
to
cc1bf1f
Compare
pguyot
force-pushed
the
w41/allow-sending-messages-from-isr
branch
14 times, most recently
from
5df5e23
to
81b4d8b
Compare
Introduce and document new functions to send messages from an interrupt service routine Add CMake option AVM_DISABLE_ISR to disable these functions as they require several synchronization and atomic primitives that are not available on all platforms Introduce the required synchronization primitives that try and acquire locks Also fix Pico networking code that sends messages from interrupt service code (as chosen lwIP mode is low-priority interrupt mode) by using these new functions Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w41/allow-sending-messages-from-isr
branch
from
81b4d8b
to
4b9711e
Compare
|
Unlike ESP32 SDK, malloc is not interrupt safe with Pico SDK on the contrary to what I thought, so this PR is useless unless we want to enable ISR callbacks on ESP32. |
|
Too bad, this looks like it was a lot of work. Can anything be salvaged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new synchronization primitives to try to acquire locks and introduce
new functions to send messages from an interrupt service routine
Also fix Pico networking code that currently does this as it's using the
low-priority interrupt mode
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later