Fix a bug in resource monitors yielding a deadlock-caused abort #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadushin
approved these changes
Oct 12, 2023
bettio
requested changes
Oct 12, 2023
When monitors down handlers were called, the processes table was locked. Yet, monitor down handler might uncarefully need to lock this table, for example to decrement a refc-binary that would be a resource with a down handler. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w41/fix-resource-monitor-deadlock
branch
from
88e0068
to
d2b21da
Compare
bettio
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When monitors down handlers were called, the processes table was locked. Yet, monitor down handler might uncarefully need to lock this table, for example to decrement a refc-binary that would be a resource with a down handler.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later