Allow sending messages to registered process with !
#1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGrumpy
force-pushed
the
send_registered
branch
from
7e74036
to
447795f
Compare
bettio
requested changes
Feb 18, 2024
src/libAtomVM/opcodesswitch.h
Outdated
| @@ -2213,7 +2213,16 @@ HOT_FUNC int scheduler_entry_point(GlobalContext *glb) | |||
| #endif | |||
|
|
|||
| #ifdef IMPL_EXECUTE_LOOP | |||
| int local_process_id = term_to_local_process_id(x_regs[0]); | |||
| term process_term = x_regs[0]; | |||
There was a problem hiding this comment.
I would call it just recipient or with any name that is not biased towards a process.
src/libAtomVM/opcodesswitch.h
Outdated
| int local_process_id = term_to_local_process_id(x_regs[0]); | ||
| term process_term = x_regs[0]; | ||
| int local_process_id; | ||
| if (term_is_atom(process_term)) { |
There was a problem hiding this comment.
I think we should check if recipient is a pid first, after that if it is an atom and registered, and as last thing just raise badarg.
UncleGrumpy
force-pushed
the
send_registered
branch
from
447795f
to
46e4b80
Compare
fadushin
reviewed
Feb 19, 2024
UncleGrumpy
force-pushed
the
send_registered
branch
5 times, most recently
from
aa82dfc
to
bb49051
Compare
bettio
requested changes
Feb 22, 2024
src/libAtomVM/opcodesswitch.h
Outdated
| local_process_id = term_to_local_process_id(recipient_term); | ||
| } else if (term_is_atom(recipient_term)) { | ||
| local_process_id = globalcontext_get_registered_process(ctx->global, term_to_atom_index(recipient_term)); | ||
| if (UNLIKELY(local_process_id == 0 )) { |
There was a problem hiding this comment.
leftover space here: if (UNLIKELY(local_process_id == 0 )) { -> if (UNLIKELY(local_process_id == 0)) {.
bettio
reviewed
Feb 22, 2024
CHANGELOG.md
Outdated
| @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Fixed | |||
|
|
|||
| - ESP32: fix i2c_driver_acquire and i2c_driver_release functions, that were working only once. | |||
| - Sending messages to registered processes using the `!` operator now works. | |||
| - Fixed bug in `OP_SEND` that would accept sending a message to any integer. | |||
There was a problem hiding this comment.
Te situation was a bit worse: we did allow send to any term without raising any error, and for integers was even working.
There was a problem hiding this comment.
I updated the explanation of the bug.
Enables sending messages to registered processes using the shorhand `!` operator. If a message is sent to an atom name that is not registered using the `!` operator a `badarg` run-time error occurs, matching OTP behaviour. closes atomvm#1011 closes atomvm#98 Signed-off-by: Winford <winford@object.stream>
UncleGrumpy
force-pushed
the
send_registered
branch
from
bb49051
to
eab4e32
Compare
bettio
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables sending messages to registered processes using the shorthand
!operator. If a message is sent to an atom name that is not registered using the!operator abadargrun-time error occurs, matching OTP behaviour.Closes #1011
Closes #98
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later