[WIP] Complete CSS selectors inside of attributes

[sadovnychyi]

This is work in progress and still requires some modifications, but I would love to hear some feedback before I will continue.

Lookup all .css, .scss and .less files in project on package activation. Look for entity.other.attribute-name.class.css or entity.other.attribute-name.id.css scopes inside of each file. This makes it work with any stylesheets supported by Atom. No need to use external CSS parser.

• Lookup for CSS scopes inside of current file as well.
• Update completions registry when new stylesheets created or updated.
• Make global parsing asynchronous for each file
• Allow to configure what to ignore – right now all VCS and Core ignored files are ignored. But sometimes we want to get autocompletions from, for example, bower_components directory
• Should we make this completions optional under an experimental setting?
• Handle events when files updated outside of Atom
• Handle file removal event

#13

[steelbrain]

Scanning a whole project on each autocomplete call is too expensive IMO

[sadovnychyi]

This is more like proof of concept. Look on my to-do list about caching.

On Wed, Dec 30, 2015, 23:50 Steel Brain notifications@github.com wrote:

In lib/provider.coffee
#21 (comment):

@@ -168,7 +170,42 @@ module.exports =

 attributePattern.exec(line)?[1]

• getAttributeValues: (attribute) ->
• getLocalStylesheets: (editor) ->
• source = editor.getText()
• while match = stylePattern.exec(source)

•  match[1]
  
• getStylesheetsAtPath: (dir) ->
• stylesheets = []
• for file in fs.readdirSync(dir)

Scanning a whole project on each autocomplete call is too expensive IMO

—
Reply to this email directly or view it on GitHub
https://github.com/atom/autocomplete-html/pull/21/files#r48611158.

[sadovnychyi]

@mnquintana @50Wliu could you guys take a look on updated implementation?

I've basically copy pasted load-paths-handler.coffee from fuzzy-finder package since looks like there are no other way to browse all project files.

It does lookup all files on package activation and updates completions index on each save event.
But it will not update completions from files created outside of atom. Also I didn't found a way to subscribe on file removal event.

Any advices?

[PixelT]

Hi,
how the progress about plugin looks like?

[florianbouvot]

@sadovnychyi is it working when styles.scss is closed (gif demo) ?

[sadovnychyi]

@florianbouvot it does. https://github.com/atom/autocomplete-html/pull/21/files#diff-43f9c4cec188d77db17033d59fb3944dR202

It scans all of ['.css', '.scss', '.less', '.html'] in your project.

I been using this branch for a long time, there's just issues that I don't have time to resolve and it's unsafe to merge without fixing them. But basically this is very usable as is.

[florianbouvot]

@sadovnychyi cool and how can we use it now ?

[sadovnychyi]

Just clone, switch the branch and apm link it, or just manually replace the package.

[florianbouvot]

@sadovnychyi thank you, I think you should consider to create a dedicated plugin 😉

[sadovnychyi]

atom/atom#14853 -- I think after this is merged it would be much easier to solve some issues here.

[florianbouvot]

@sadovnychyi I clone sadovnychyi:master and apm link it but it doesn't seem to work. I didn't know which branch to choose, can you help me ?

atom/atom#14853 -- I think after this is merged it would be much easier to solve some issues here.

I understand 😉

[a7madgamal]

need this BADLY :(

[vinkla]

Is this pull request still alive? What can one do to help? I'm guessing this pull request needs to be decaffeinated before it can be merged?

[sadovnychyi]

@vinkla I think there's language servers available for this now, would make sense to use one of those.