Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writeString() length integer does not include the null terminator #1

Closed
jhurliman opened this issue Jun 25, 2021 · 1 comment
Closed

writeString() length integer does not include the null terminator #1

jhurliman opened this issue Jun 25, 2021 · 1 comment

Comments

@jhurliman
Copy link

The uint32 that is serialized is s.length, which does not include the extra byte for the 0x00 null terminator.
@JEnoch JEnoch closed this as completed in 165e3c9 Jun 28, 2021
@JEnoch
Copy link
Member

JEnoch commented Jun 28, 2021

Thanks for spotting this!
The fix is now available in v0.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhurliman @JEnoch