Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useLayoutEffect warning during SSR (improve useIsomorphicLayoutEffect check) #1623

Closed
LinusCenterstrom opened this issue Nov 21, 2019 · 0 comments · Fixed by #1636
Closed

Comments

@LinusCenterstrom
Copy link
Contributor

Expected behavior

There is a warning during SSR because window is defined, I would expect there to be no warning.

Suggested solution

Update use-isomorphic-layout-effect to check for window, window.document and window.document.createElement instead of just window.
That would match what both React and Redux are doing

What version of React are you using?

16.8.6

What version of react-beautiful-dnd are you running?

12.0.0

What browser are you using?

Chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant