Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

external-editor-program must be only specified as a string #3240

Closed
aadcg opened this issue Oct 24, 2023 · 2 comments · Fixed by #3253
Closed

external-editor-program must be only specified as a string #3240

aadcg opened this issue Oct 24, 2023 · 2 comments · Fixed by #3253
Assignees
@aadcg
Labels
4-series Related to releases whose major version is 4.

Comments

@aadcg
Copy link
Member

aadcg commented Oct 24, 2023

As to simplify the API. The acceptance of a list of strings will be deprecated.
@aadcg aadcg added the 4-series Related to releases whose major version is 4. label Oct 24, 2023
@jmercouris
Copy link
Member

Well, whichever one is easier to implement programmatically. One or the other, not both.

@aadcg
Copy link
Member Author

aadcg commented Oct 29, 2023 •
edited
Loading

Since the default value is set to the value of env vars, then it must be a string. Also "program arg" is more intelligible than '("program" "arg") .

@aadcg aadcg self-assigned this Oct 29, 2023
@aadcg aadcg mentioned this issue Nov 13, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aadcg aadcg

Labels
4-series Related to releases whose major version is 4.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor external editor program api atlas-engineer/nyxt
2 participants
@jmercouris @aadcg