From ddabcf7914f1d14fcef75bf4af39cdb559a63964 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Vo=C5=99=C3=AD=C5=A1ek?= Date: Wed, 30 Aug 2023 23:17:31 +0200 Subject: [PATCH] improve cs --- src/Persistence/Array_/Action.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Persistence/Array_/Action.php b/src/Persistence/Array_/Action.php index 156ec721d..68da7d714 100644 --- a/src/Persistence/Array_/Action.php +++ b/src/Persistence/Array_/Action.php @@ -76,9 +76,9 @@ public function aggregate(string $fx, string $field, bool $coalesce = false) break; case 'AVG': - $column = $coalesce ? $column : array_filter($column, static function ($value) { - return $value !== null; - }); + if (!$coalesce) { // TODO add tests and verify against SQL + $column = array_filter($column, static fn ($v) => $v !== null); + } $result = array_sum($column) / count($column);