Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable blocks #60

Closed
tangjeff0 opened this issue May 15, 2020 · 5 comments
Closed

Editable blocks #60

tangjeff0 opened this issue May 15, 2020 · 5 comments

Comments

@tangjeff0
Copy link
Collaborator

Feature

Usually, blocks are rendered as divs and spans. In order to change their contents (i.e. :block/string), you must click on the block. This changes the block to an editable <textarea>. When you click out, the block turns back into divs and spans.

Demo

textarea

@Bardia95
Copy link
Contributor

Working on it!

@tangjeff0
Copy link
Collaborator Author

Are you able to assign yourself? Might be better to use that feature than commenting :)

@Bardia95
Copy link
Contributor

#70
Can you guys code review my pull request when you get a chance? Be as critical as you want, I want as much feedback as you are willing to give me.
@tangjeff0 @jeroenvandijk

@tangjeff0
Copy link
Collaborator Author

Awesome will take a look tomorrow @Bardia95

@roryokane
Copy link
Contributor

There was more discussion about textarea/input vs. contenteditable on Discord. Find the dicussion by searching for messages in the #engineering channel on 2020-05-22 starting with a message by @jelmerderonde (Discord user #1069), or by following this link to that first message.

@roryokane roryokane mentioned this issue May 26, 2020
6 tasks
This was referenced May 27, 2020
@tangjeff0 tangjeff0 reopened this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants