Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

at.fast_ring functions need to be cleaned up #529

Open
lcarver opened this issue Nov 30, 2022 · 4 comments
Open

at.fast_ring functions need to be cleaned up #529

lcarver opened this issue Nov 30, 2022 · 4 comments
Assignees
Labels
Python For python AT code

Comments

@lcarver
Copy link
Contributor

lcarver commented Nov 30, 2022

No description provided.

@lcarver lcarver added the Python For python AT code label Nov 30, 2022
@lcarver lcarver self-assigned this Nov 30, 2022
@lfarv
Copy link
Contributor

lfarv commented Nov 30, 2022

Agreed. I was about to fully rewrite both python and Matlab versions. It can be made much simpler!

@lcarver
Copy link
Contributor Author

lcarver commented Nov 30, 2022

The initial implementation of pyat fast_ring was heavily influenced by the matlab version so the logic is quite similar and not very pythonic. It can be significantly improved.

@lfarv
Copy link
Contributor

lfarv commented Nov 30, 2022

I have versions rewritten from scratch which are much cleaner !

@swhite2401
Copy link
Contributor

For periodic lattices I would suggest to always develop the ring before generating the fastring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python For python AT code
Projects
None yet
Development

No branches or pull requests

3 participants