-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Multiple Reports #21
Comments
Ditto, this is a must! Currently, it only uses the last report. Ideally, it should use all reports |
I believe this might be related to #35 |
Hi all, As part of this I added a new optional input Can you test |
You can also try combining reports like this comment in #38 |
@ataylorme in our case, we're dealing with reports generated across multiple Workflows (not within the same Workflow). In any case, would love to kick the tires on v2 when it's ready since |
@jason-yolabs v2 is ready to go now (it has been merged). You can update the version in your workflow files to |
Thanks for creating this action! I am currently using it in a monorepo where I have 2 different projects, each of which have their own Github Workflows for linting when a PR is created. Here's an example of one of the workflow files, the other is almost identical except from the paths/working-directory.
If I create a PR that has file changes to both projects, currently both workflows are triggered as expected and produce the ESLint results as a JSON file. Unfortunately it seems that one set of annotations overwrites the other set, so I only see half of the ESLint issues I'd expect to see. (Notice the missing
no-unused-vars
error frommobile-client/src/App.js
)I'm not sure if that's a limitation of Github Actions/Checks, or if it's something that could be supported by this action?
I think for now I can get around it by having a single workflow lint both projects at the same time to avoid the annotations being overwritten.
As a sidenote I also seem to be getting the following warning, even though the
only-pr-files
input is documented in the README?The text was updated successfully, but these errors were encountered: