Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateInput: would like to control icon size and position (padding) #22

Open
juanlanus opened this issue Oct 21, 2019 · 0 comments
Open

Comments

@juanlanus
Copy link

I like this DateInput control very much, only I can't set my ducks in a row.
See the picture.
Screenshot from 2019-10-21 19-04-19
I would like to set a smaller calendar icon in a position and with a size aligned with the icons of the other controls below.

Additionally, there is an issue with the "size" prop, that along the Grommet controls lineup is applied to the control's size but in this one it is applied to the size of the drop. This might be a source of confusion in the future when this stuff is used by millions.
Maybe this prop should follow the Grommet Select's pattern and be dropSize.

In a component of mine, which has an icon, I pass an icon prop that is an object and inside that object I can control as many icon properties as I want to.
Being that Grommet has a relevant icons set, this might be useful in this DateInput and in any other artifact where an icon is part of the thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant