chore: update meetings.json and newsrooom_videos.json #3672
Conversation
asyncapi-bot
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThis pull request adds two meeting entries in the meetings configuration file and updates the newsroom videos configuration. The meetings file now includes a "Design Meeting" and an "AsyncAPI Community Working Group Meeting" with associated dates, calendar links, URLs, and banner details. The newsroom videos file gains a new video entry corresponding to the community working group meeting while an outdated video entry is removed. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant S as System
User->>S: Request meetings configuration
S-->>User: Return meetings.json with two new meeting entries
User->>S: Request videos configuration
S-->>User: Return newsroom_videos.json with updated video entries
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3672 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 732 732
=========================================
Hits 732 732 ☔ View full report in Codecov by Sentry. |
asyncapi-bot
deleted the
update-meetings/a3dc30d57cb3dfc68b1b091dbaa4789224495cc5
branch
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
config/meetings.json (2)
66-66: Maintain consistent meeting titles.The title "Design Meeting" differs from the previously used "Design Call" (line 17). Consider using consistent naming across all design-related meetings.
- "title": "Design Meeting", + "title": "Design Call",
76-76: Consider using a unique banner for each meeting.The banner URL is reused from a previous Community Working Group Meeting (line 55). Consider using unique banners for each meeting to help distinguish between different sessions.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(1 hunks)config/newsroom_videos.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (2)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
🔇 Additional comments (2)
config/newsroom_videos.json (1)
3-3: Verify video ID consistency.The video ID in the image URL matches the videoId field. This is correct.
Also applies to: 6-6
config/meetings.json (1)
67-68: Verify the validity of calendar links and GitHub issues.Please ensure that the calendar links and GitHub issue links are accessible and correctly configured.
Also applies to: 74-75
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Description: Check if the GitHub issues exist and are accessible # Check GitHub issues for issue in 1711 1713; do echo "Checking issue #$issue..." gh issue view $issue --repo asyncapi/community doneLength of output: 6483
Calendar and GitHub Links Verified
- The GitHub issues (docs: add CynthiaPeter as a contributor for doc #1711 and docs: document adding bindings #1713) are accessible, open, and properly configured as confirmed by the script output.
- A curl check of the calendar link indicates it’s publicly reachable (HTTP response code confirms accessibility).
| { | ||
| "image_url": "https://i.ytimg.com/vi/sWrD820od7s/hqdefault.jpg", | ||
| "title": "AsyncAPI Community Working Group Meeting", | ||
| "description": "https://github.com/asyncapi/community/issues/1668.", | ||
| "videoId": "sWrD820od7s" | ||
| }, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Improve the description field content.
The description field contains a URL instead of an actual description of the video content. Consider replacing it with a meaningful description of the meeting's content and objectives.
{
"image_url": "https://i.ytimg.com/vi/sWrD820od7s/hqdefault.jpg",
"title": "AsyncAPI Community Working Group Meeting",
- "description": "https://github.com/asyncapi/community/issues/1668.",
+ "description": "AsyncAPI Community Working Group Meeting discussing community initiatives and project updates. For more details, visit: https://github.com/asyncapi/community/issues/1668",
"videoId": "sWrD820od7s"
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { | |
| "image_url": "https://i.ytimg.com/vi/sWrD820od7s/hqdefault.jpg", | |
| "title": "AsyncAPI Community Working Group Meeting", | |
| "description": "https://github.com/asyncapi/community/issues/1668.", | |
| "videoId": "sWrD820od7s" | |
| }, | |
| { | |
| "image_url": "https://i.ytimg.com/vi/sWrD820od7s/hqdefault.jpg", | |
| "title": "AsyncAPI Community Working Group Meeting", | |
| "description": "AsyncAPI Community Working Group Meeting discussing community initiatives and project updates. For more details, visit: https://github.com/asyncapi/community/issues/1668", | |
| "videoId": "sWrD820od7s" | |
| } |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit