Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage maintainers are not pinged in relevant PRs #2634

Closed
akshatnema opened this issue Feb 6, 2024 · 2 comments · Fixed by #2660
Closed

Triage maintainers are not pinged in relevant PRs #2634

akshatnema opened this issue Feb 6, 2024 · 2 comments · Fixed by #2660
Assignees

Comments

@akshatnema
Copy link
Member

Describe the bug

Recently with the additions of new triage maintainers in the website, CODEOWNERS file (https://github.com/asyncapi/website/blob/master/CODEOWNERS) has got into multiple errors. These errors are because of providing only Triage access to the new maintainers. Hence, none of the new joines are pinged whenever there is a new PR opened.

Expected behavior

With each PR opened or changes pushed, relevant triage maintainers should get a ping with either a comment inside PR or adding them to reviewers list of PR.

Proposed solution

Using Github APIs, you can try to add reviewers on the PR open or update using Github workflows.

@akshatnema
Copy link
Member Author

cc: @TRohit20 @VaishnaviNandakumar

@TRohit20
Copy link
Collaborator

TRohit20 commented Feb 6, 2024

Working on fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants