Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Github Actions to make it work with monorepos #651

Closed
Tracked by #636
fmvilas opened this issue Jun 8, 2023 · 7 comments · Fixed by #706
Closed
Tracked by #636

Adapt Github Actions to make it work with monorepos #651

fmvilas opened this issue Jun 8, 2023 · 7 comments · Fixed by #706
Assignees

Comments

@fmvilas
Copy link
Member

fmvilas commented Jun 8, 2023

The release process that we have on AsyncAPI is meant to work with repositories containing a single application or package. Since we want to make this repo a monorepo, we need to adapt the release process too.

@Shurtu-gal
Copy link
Collaborator

@fmvilas can I work upon this?

@KhudaDad414
Copy link
Member

@Shurtu-gal Actually I am working on it right now. 😄

@Shurtu-gal
Copy link
Collaborator

Shurtu-gal commented Jun 8, 2023

Sure, happy to help if needed. 🚀 @KhudaDad414

@KhudaDad414
Copy link
Member

/progress 90

this PR is going to solve the current issue that we are facing with craco. the workflow has been tested here but I haven't had a successful because of the docker issue in the studio app, in theory it should work in the main repo. other packages publish fine.

@KhudaDad414
Copy link
Member

/progress 40

since we are using docker to publish the studio as a docker image, figuring out how to do it in a monorepo since there is no package-lock.json in each app, so the docker publishing process needs to be reevaluated.

@fmvilas
Copy link
Member Author

fmvilas commented Jun 22, 2023

In case it helps, I found this: npm/rfcs#554.

@KhudaDad414
Copy link
Member

/progress 95

changesets are going to replace the semantic-release processes. PR is ready for review. #706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants