Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistancy in components #403

Merged

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Jun 15, 2023

Description
This PR cleanup some inconsistencies in components.

  • schemas could be defined with any name, now it matches the regular expression: ^[a-zA-Z0-9.-_]+$
  • servers could be defined with any name, now it matches the regular expression: ^[a-zA-Z0-9.-_]+$
  • channels could be defined with any name, now it matches the regular expression: ^[a-zA-Z0-9.-_]+$
  • serverVariables could be defined with any name, now it matches the regular expression: ^[a-zA-Z0-9.-_]+$
  • parameters could be defined with any name, now it matches the regular expression: ^[a-zA-Z0-9.-_]+$
  • operationTraits could be defined with any name, now it matches the regular expression: ^[a-zA-Z0-9.-_]+$
  • messageTraits could be defined with any name, now it matches the regular expression: ^[a-zA-Z0-9.-_]+$
  • serverBindings could be defined with any name, now it matches the regular expression: ^[a-zA-Z0-9.-_]+$
  • channelBindings could be defined with any name, now it matches the regular expression: ^[a-zA-Z0-9.-_]+$
  • operationBindings could be defined with any name, now it matches the regular expression: ^[a-zA-Z0-9.-_]+$
  • messageBindings could be defined with any name, now it matches the regular expression: ^[a-zA-Z0-9.-_]+$
  • operationTraits could not be defined with references.
  • messageTraits could not be defined with references.
  • serverBindings could not be defined with references.
  • channelBindings could not be defined with references.
  • operationBindings could not be defined with references.
  • messageBindings could not be defined with references.

@jonaslagoni
Copy link
Member Author

/rtm

@jonaslagoni
Copy link
Member Author

/rtm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@asyncapi-bot asyncapi-bot merged commit edcf7da into asyncapi:next-major-spec Jun 26, 2023
@jonaslagoni jonaslagoni deleted the inconsistancy_components branch June 26, 2023 19:23
@jonaslagoni
Copy link
Member Author

Thanks @fmvilas 🙏

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0-next-major-spec.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants