Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support JSON input and output #37

Merged
merged 10 commits into from
Oct 4, 2021
Merged

feat: support JSON input and output #37

merged 10 commits into from
Oct 4, 2021

Conversation

KhudaDad414
Copy link
Member

Description

  • This PR will add support for JSON input and output.
  • For input, pass JSON, YAML or Object into the Optimizer class constructor.
  • Output can be customized by passing {output: 'JSON' | 'YAML'} into the getOptimizedDocument() function.

Related issue(s)
Resolves #15

@KhudaDad414 KhudaDad414 changed the title feat: Support JSON input and output feat: support JSON input and output Sep 17, 2021
@KhudaDad414 KhudaDad414 marked this pull request as ready for review September 17, 2021 11:14
magicmatatjahu
magicmatatjahu reviewed Sep 20, 2021
View reviewed changes
src/Utils/Helpers.ts Outdated Show resolved Hide resolved
src/Utils/Helpers.ts Outdated Show resolved Hide resolved
@magicmatatjahu
Copy link
Member

@KhudaDad414 Is PR for review?

@KhudaDad414
Copy link
Member Author

@KhudaDad414 Is PR for review?

Yes it is. I answered the question that you asked in the previous review and have been waiting since. 😐

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Sep 28, 2021 •
edited
Loading

@KhudaDad414

Yes it is. I answered the question that you asked in the previous review and have been waiting since. 😐

So please make rerequest to me (this "loading" icon) :)

image

I don't know if you made changes because I didn't get notifications. If you inform me again about the changes via rerequest then I will show them.

magicmatatjahu
magicmatatjahu reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, but last suggestion :)

src/Utils/Helpers.ts Outdated Show resolved Hide resolved
magicmatatjahu
magicmatatjahu reviewed Oct 4, 2021
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhudaDad414 Sorry for such a long delay. Everything is fine, just please fix conflicts with package.json and package-lock.json :)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

magicmatatjahu
magicmatatjahu approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work!

@KhudaDad414 KhudaDad414 merged commit 3d45279 into master Oct 4, 2021
@KhudaDad414 KhudaDad414 deleted the support-json-for-input-output branch October 4, 2021 14:03
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JSON and JSON string support for input and output.
3 participants
@KhudaDad414 @magicmatatjahu @asyncapi-bot