Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for urls without protocol #48

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

KhudaDad414
Copy link
Member

Description

  • this will fix the issue with URLs that do not contain a protocol at the start of the URL in AsyncAPI file.
  • currently, this template will generate a Nodejs project with the wrong URL in the config/common.yml file.

Related issue(s)
Resolves #47

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KhudaDad414 KhudaDad414 changed the title Url Protocol issue solved. fix: url without protocol issue solved. Mar 23, 2021
@derberg derberg changed the title fix: url without protocol issue solved. fix: support for urls without protocol Mar 24, 2021
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix. I will approve and merge even though quality gate fails because it is about code that you did not touch in your PR

@derberg derberg merged commit b67e10d into asyncapi:master Mar 24, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

kaushik-rishi pushed a commit to kaushik-rishi/nodejs-template that referenced this pull request Aug 23, 2023
ci: update global workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server URL without protocol issue.
3 participants