Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(c#): generated enum extension methods lead to invalid references #746

Merged
merged 4 commits into from
May 23, 2022
Merged

fix(c#): generated enum extension methods lead to invalid references #746

merged 4 commits into from
May 23, 2022

Conversation

Polygens
Copy link
Contributor

@Polygens Polygens commented May 7, 2022

Description
As mentioned in #700 the generated serializer code using enums did not match with the enum generated code.
This led to invalid code that required manual fixing. This tiny PR aligns both generators.

Related issue(s)

Fixes #700

@Polygens Polygens requested a review from ron-debajyoti as a code owner May 7, 2022 07:40
@Polygens Polygens changed the title fix(C#): Generated enum extension methods lead to invalid references fix(c#): generated enum extension methods lead to invalid references May 7, 2022
@coveralls
Copy link

coveralls commented May 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2345997168

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.105%
Totals Coverage Status
Change from base Build 2345953286: 0.0%
Covered Lines: 2806
Relevant Lines: 2904
💛 - Coveralls

@jonaslagoni
Copy link
Member

@ron-debajyoti need your review as well 🙂

@jonaslagoni
Copy link
Member

/rtm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni jonaslagoni merged commit 63bdd44 into asyncapi:master May 23, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.59.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@ron-debajyoti ron-debajyoti ron-debajyoti approved these changes

Assignees
No one assigned
Labels
ready-to-merge released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C#] Generated enum extension methods lead to invalid references
5 participants
@Polygens @coveralls @jonaslagoni @asyncapi-bot @ron-debajyoti