Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude _ from Java key enum rendering #737

Merged
merged 1 commit into from
Apr 27, 2022
Merged

fix: exclude _ from Java key enum rendering #737

merged 1 commit into from
Apr 27, 2022

Conversation

Samridhi-98
Copy link
Collaborator

Description

  • Modified java/EnumRenderer.ts
  • Added java/renderer/EnumRenderer.spec.ts

Related issue(s)

Fixes #687

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2232881583

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.989%
Totals Coverage Status
Change from base Build 2230432462: 0.0%
Covered Lines: 2632
Relevant Lines: 2703
💛 - Coveralls

jonaslagoni
jonaslagoni approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@jonaslagoni jonaslagoni merged commit 15964bc into asyncapi:master Apr 27, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.56.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Samridhi-98 Samridhi-98 deleted the exclude_from_java branch April 28, 2022 06:51
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude _ from Java key enum rendering
4 participants
@Samridhi-98 @coveralls @asyncapi-bot @jonaslagoni