Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: complete model rendering and file output for Go generator #540

Merged
merged 11 commits into from
Jan 11, 2022
Merged

feat: complete model rendering and file output for Go generator #540

merged 11 commits into from
Jan 11, 2022

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Dec 21, 2021 •
edited
Loading

Description
This PR adds both complete model rendering and file output for the Go generator.

Related issue(s)
Fixes #398

@jonaslagoni
Copy link
Member Author

@smoya maybe you want to have a look as well? 🙂

@jonaslagoni
Copy link
Member Author

And I have no idea why this is failing...

@coveralls
Copy link

coveralls commented Jan 5, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1681938905

  • 20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 93.423%
Totals Coverage Status
Change from base Build 1681913932: 0.06%
Covered Lines: 2366
Relevant Lines: 2414
💛 - Coveralls

@jonaslagoni jonaslagoni requested a review from smoya January 5, 2022 15:29
@jonaslagoni jonaslagoni mentioned this pull request Jan 5, 2022
Merged
smoya
smoya previously approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor. LGTM otherwise

magicmatatjahu
magicmatatjahu approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@jonaslagoni
Copy link
Member Author

/rtm

@jonaslagoni
Copy link
Member Author

Thanks for the reviews @smoya @magicmatatjahu 🙇

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni jonaslagoni merged commit cafc1ff into asyncapi:master Jan 11, 2022
@jonaslagoni jonaslagoni deleted the feature/go_fileoutput branch January 11, 2022 10:29
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoya smoya smoya approved these changes

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generating Go models directly to files
5 participants
@jonaslagoni @coveralls @asyncapi-bot @smoya @magicmatatjahu