This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
feat: configure extra message route to publish validationErrors to Kafka topic #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
commented
Oct 11, 2021
| type ValidationErrorNotifier func(validationError *ValidationError) error | ||
|
|
||
| // ValidationErrorToChanNotifier notifies to a given chan when a ValidationError happens. | ||
| func ValidationErrorToChanNotifier(errChan chan *ValidationError) ValidationErrorNotifier { |
There was a problem hiding this comment.
All of this has been removed in favor of using publisher through watermill.io routes.
smoya
commented
Oct 11, 2021
| @@ -60,6 +56,14 @@ func NewProxy(c *ProxyConfig) (proxy.Proxy, error) { | |||
| _ = server.Server.Flags().Set("log-level", "debug") | |||
| } | |||
|
|
|||
| if c.TLS != nil && c.TLS.Enable { | |||
There was a problem hiding this comment.
This was previously configured through the c ExtraConfig but now they have been moved into the config directly as it is important to be explicit. In that way, the TLS config can be reused into other parts.
smoya
commented
Oct 11, 2021
|
|
||
| opts := []kafka.ProxyOption{kafka.WithMessageHandler(handler.ValidateMessage(validator, false))} | ||
|
|
||
| if c.MessageValidation.PublishToKafkaTopic == "" { |
There was a problem hiding this comment.
If the topic is set (from env var atm), then all the re-routing to publish the messages back into Kafka (but another topic) is configured.
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
magicmatatjahu
approved these changes
Oct 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #37
This PR adds support for configuring an extra publisher for incoming Kafka messages so they can be published again to another topic after validation (Same kafka cluster, different topic).
Now, validated messages that got a validation error can be re-enqueued to another kafka topic so they can be consumed by someone else and run forensics on their own. In this case, we will be exposing those by default to the websocket port by consuming directly from the second configured topic.
The
asyncapi.yamlhas also changed since the validation errors are now injected to the Metadata (headers) of the Message model, so they can be reused, rerouted, etc.Related issue(s)
#37