This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
feat: use watermill as routing framework #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
approved these changes
Oct 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This resolves #43.
TL;DR: this sets the base for routing messages by using Watermill.io framework.
Using Watermill.io will reduce the complexity of the code, simplify the routing and message handling and reduce the time spent on all those efforts. Even though more work will be needed around app configuration, things like #37 have become now more trivial; adding a new handler to the Watermill router will subscribe to incoming Kafka messages and send them to a Kafka topic. Adding a second handler, those will be consumed by a process that will send them to the websocket clients.
I'm pretty excited for the simplicity of Watermill.io framework and how it simplifies most of the operation.
Related issue(s)
#43