feat(config): remove support for configuring kafka broker from env vars #51
Conversation
| | EVENTGATEWAY_KAFKA_PROXY_MESSAGE_VALIDATION_ENABLED | boolean | Enable or disable validation of Kafka messages | `true` | No | `true`, `false` | | ||
| | EVENTGATEWAY_KAFKA_PROXY_EXTRA_FLAGS | string | Advanced configuration. Configure any flag from [here](https://github.com/grepplabs/kafka-proxy/blob/4f3b89fbaecb3eb82426f5dcff5f76188ea9a9dc/cmd/kafka-proxy/server.go#L85-L195). Multiple values can be configured by using pipe separation (`\|`) | - | No | `tls-enable=true\|tls-client-cert-file=/opt/var/service.cert\|tls-client-key-file=/opt/var/service.key` | |
There was a problem hiding this comment.
I don't see any code where you read these values from envs and save them to the KafkaProxy struct. Are you using any env parsing library or are these envs will be removed?
There was a problem hiding this comment.
I'm using https://github.com/kelseyhightower/envconfig which is pretty common nowadays.
There was a problem hiding this comment.
One thing puzzles me. Is a variable EVENTGATEWAY_KAFKA_PROXY_MESSAGE_VALIDATION_ENABLED well read if it has suffix _ENABLED and in the structure the variable is without this suffix (MessageValidation)?
There was a problem hiding this comment.
The value we are setting here is the Enabled struct property of MessageValidation. You can see it here: https://github.com/smoya/event-gateway/blob/chore/messagePackage/config/kafka.go#L28.
envconfig works by generating flags with the name based on the structs hierarchy. Let me explain with the example EVENTGATEWAY_KAFKA_PROXY_MESSAGE_VALIDATION_ENABLED:
EVENTGATEWAYis the prefix for the app. This is set manually when startingenvconfig. See https://github.com/smoya/event-gateway/blob/chore/messagePackage/main.go#L22KAFKA_PROXYis theKafkaProxyproperty for the structConfig. See it here: https://github.com/smoya/event-gateway/blob/chore/messagePackage/config/config.go#L14MESSAGE_VALIDATIONis theMessageValidationproperty for the structKafkaProxy. You can see it here: https://github.com/smoya/event-gateway/blob/chore/messagePackage/config/kafka.go#L22ENABLEDis theEnabledproperty for the structMessageValidation. You can see it here: https://github.com/smoya/event-gateway/blob/chore/messagePackage/config/kafka.go#L28
Description
Fixes #50.
This PR drops the option to configure Kafka broker mappings from env vars. Instead, it forces the user to use AsyncAPI, which becomes the main config source from now on.
Related issue(s)
#50