This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
feat(model): add message model and dependants #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmvilas
reviewed
Jul 19, 2021
Schema() Schema | ||
} | ||
|
||
// OperationType is the type of an operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL really?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go Doc is amazing ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow me for more documentation advice 😂
fmvilas
approved these changes
Jul 19, 2021
magicmatatjahu
suggested changes
Jul 19, 2021
magicmatatjahu
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds all main models needed for getting all required info the app needs for validating messages based on an AsyncAPI document.
Note that there are some
TODO
comments. As this is based on https://github.com/asyncapi/parser-api/blob/master/docs/v1.md and it's becoming the first implementation, there is some uncertainty around. Issues and/or PR's will be created against https://github.com/asyncapi/parser-api whenever we keep moving forward with the development but most probably once we start migrating all theasyncapi
package to https://github.com/asyncapi/parser-go.TO clarify, all those TODO won't affect the behavior of this application (or at least is not expected by now).
Related issue(s)
Code needed for #10