Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

feat(model): add message model and dependants #20

Merged
merged 4 commits into from
Jul 19, 2021

Conversation

smoya
Copy link
Collaborator

@smoya smoya commented Jul 19, 2021

Description

This PR adds all main models needed for getting all required info the app needs for validating messages based on an AsyncAPI document.

Note that there are some TODO comments. As this is based on https://github.com/asyncapi/parser-api/blob/master/docs/v1.md and it's becoming the first implementation, there is some uncertainty around. Issues and/or PR's will be created against https://github.com/asyncapi/parser-api whenever we keep moving forward with the development but most probably once we start migrating all the asyncapi package to https://github.com/asyncapi/parser-go.
TO clarify, all those TODO won't affect the behavior of this application (or at least is not expected by now).

Related issue(s)
Code needed for #10

@smoya smoya requested review from fmvilas and magicmatatjahu July 19, 2021 15:33
@smoya smoya added the enhancement New feature or request label Jul 19, 2021
Schema() Schema
}

// OperationType is the type of an operation.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL really?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Doc is amazing ...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow me for more documentation advice 😂

asyncapi/document.go Outdated Show resolved Hide resolved
asyncapi/document.go Outdated Show resolved Hide resolved
asyncapi/document.go Outdated Show resolved Hide resolved
@smoya smoya requested a review from magicmatatjahu July 19, 2021 17:53
Copy link
Collaborator

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smoya smoya merged commit cd5268b into asyncapi-archived-repos:master Jul 19, 2021
@smoya smoya deleted the feat-more-models branch July 19, 2021 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants