-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS file #668
Comments
Hey @peter-rr
I assume your goal is to become an official maintainer for @Souvikns @magicmatatjahu anything from your side? |
I feel like a lot of contributors don't know this, we should add it in our contributor guide or something.
@derberg if you are asking that should we make @peter-rr maintainer or not then I vote yes, and I think @peter-rr you can still review the code even if you are not a maintainer. |
Yes, I also did not know till now. |
yeah, we definitely need more docs and luckily we now have a place where to put them https://www.asyncapi.com/docs/community. Documenting it is on the list in asyncapi/website#903, we just need someone to contribute |
@Souvikns no no, anyone can be maintainer, and if @peter-rr goal is to be one, we should support that. Actually the more maintainers, the easier maintenance for those that are outnumbered 😄 But to be a maintainer you need to show that you can actually be one, and other maintainers can trust you accepting PR (enabling them to be merged). Perfect example is @akshatnema that became maintainer for website, by not only contributing features but also participating in review big time. This way I could see what he looks at, how he approach people and I 💯 trust he accepts PRs and the direction of the project is understood. So, I'm definitely ok, but not now. For me it is important that @peter-rr shows his activity in:
I hope you know what you mean 😄 PS. I think it is a first time someone openly asks about it, and it can end up as a document/guide for maintainer-candidates |
Alright! Thanks for the detailed explanation 👌 |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Reason/Context
I would like to be able to review and merge commits into the CLI to help out.
Let me know what you think :)
Description
CODEOWNERS file needs to be updated in that case: https://github.com/asyncapi/cli/blob/5aa4bbe3df0517feda06908909824f478206c241/CODEOWNERS
The text was updated successfully, but these errors were encountered: