Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS file #668

Closed
peter-rr opened this issue Jun 27, 2023 · 7 comments
Closed

Update CODEOWNERS file #668

peter-rr opened this issue Jun 27, 2023 · 7 comments
Labels
enhancement New feature or request stale

Comments

@peter-rr
Copy link
Member

Reason/Context

I would like to be able to review and merge commits into the CLI to help out.
Let me know what you think :)

Description

CODEOWNERS file needs to be updated in that case: https://github.com/asyncapi/cli/blob/5aa4bbe3df0517feda06908909824f478206c241/CODEOWNERS

@peter-rr peter-rr added the enhancement New feature or request label Jun 27, 2023
@derberg
Copy link
Member

derberg commented Jun 28, 2023

Hey @peter-rr
You do not have to be the codeowner/maintainer to review or merge PRs

  • anyone can review a PR or triage issues. It is actually also encouraged for future maintainers to do it before joining
  • anyone can merge a PR, this is why we have /rtm command in place

I assume your goal is to become an official maintainer for cli repo. To be a maintainer you need to regularly contribute, participate in reviews, help solving bugs - basically show you know the project well so you can later as maintainer approve changes. Does that make sense?

@Souvikns @magicmatatjahu anything from your side?

@Souvikns
Copy link
Member

anyone can merge a PR, this is why we have /rtm command in place

I feel like a lot of contributors don't know this, we should add it in our contributor guide or something.

I assume your goal is to become an official maintainer for cli repo. To be a maintainer you need to regularly contribute, participate in reviews, help solving bugs - basically show you know the project well so you can later as maintainer approve changes. Does that make sense?

@derberg if you are asking that should we make @peter-rr maintainer or not then I vote yes, and I think @peter-rr you can still review the code even if you are not a maintainer.

@chinma-yyy
Copy link
Contributor

I feel like a lot of contributors don't know this, we should add it in our contributor guide or something.

Yes, I also did not know till now.

@derberg
Copy link
Member

derberg commented Jun 29, 2023

Yes, I also did not know till now.

yeah, we definitely need more docs and luckily we now have a place where to put them https://www.asyncapi.com/docs/community. Documenting it is on the list in asyncapi/website#903, we just need someone to contribute

@derberg
Copy link
Member

derberg commented Jun 29, 2023

@derberg if you are asking that should we make @peter-rr maintainer or not then I vote yes

@Souvikns no no, anyone can be maintainer, and if @peter-rr goal is to be one, we should support that. Actually the more maintainers, the easier maintenance for those that are outnumbered 😄

But to be a maintainer you need to show that you can actually be one, and other maintainers can trust you accepting PR (enabling them to be merged). Perfect example is @akshatnema that became maintainer for website, by not only contributing features but also participating in review big time. This way I could see what he looks at, how he approach people and I 💯 trust he accepts PRs and the direction of the project is understood.

So, I'm definitely ok, but not now. For me it is important that @peter-rr shows his activity in:

  • review of new PR. The best if he now regularly watch PRs, and acts as first reviewer to new incoming PRs
  • jumps in review in some existing PRs
  • look into some bugs and tries to help solving them, especially if they are related to features that he added
  • look into some old issues and triage them on what is their status

I hope you know what you mean 😄
Thoughts folks?

PS. I think it is a first time someone openly asks about it, and it can end up as a document/guide for maintainer-candidates

@peter-rr
Copy link
Member Author

peter-rr commented Jul 3, 2023

Alright! Thanks for the detailed explanation 👌
I totally agree with that criteria in order to be a maintainer. It does make sense to me! 👍

Copy link
Contributor

github-actions bot commented Nov 1, 2023

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Nov 1, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

4 participants