-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn CLI messages to constants #21
Comments
@magicmatatjahu shall I start with this issues, next? |
Loading spec from remote source is more important - #1 (comment) :) |
The help string also does not say what contexts are, so @derberg should we update the help text to talk about the context in a detailed manner or add have a better error message for this scenario? I think the help message is a general version of all our commands and if we write what is a context there, it could get cluttered so shall we have command level help messages to talk about specific commands. In general, we have to help the user understand how he can pass in spec file to the CLI.
|
We simply need more structured and formated info, if we do it, then it won't get cluttered. Look at help section here https://clig.dev/#help and the jq example. |
Then I guess we can solve this issue by updating the help command or adding a context section in the help string so as to talk about what context does, and how could users benefit from it.
|
we need more complex, and contextual help:
I think better would be to first refactor help to constants to have simple PR to handle and then in another issue discuss help texts. Let us have as small and focused PRs as possible |
Does this mean the help string will now be something like this ⬇ where the help string is made up of smaller constants? const helpString = `
Usage:
${USAGE_STRING}
` |
it depends but in short, yes 😄 help shown after calling In case of messages like |
🎉 This issue has been resolved in version 0.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
please create another followup issue to turn these messages into constants so we reuse them in components and tests, something like https://github.com/asyncapi/asyncapi-react/blob/master/library/src/constants.ts
no need to fix it now, not related to this pr
Originally posted by @derberg in #14 (comment)
The text was updated successfully, but these errors were encountered: