-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: created custom help message #126
Conversation
This is was causing the test cases to fail.
@Souvikns just curious why we need to ignore so many files in the case of Sonar Cloud scans? |
It was showing some function is bigger than it should be, but in this case, it is needed, and in the command directory there were some warnings for the function naming conventions, which were needed by oclif to work correctly, |
@Souvikns but we are ignoring not specific file but all
|
@Souvikns Also, if you need to disable sonar (not eslint, but exactly sonar cloud) only for certain function, you can add comment
|
I will be removing the |
@derberg @magicmatatjahu I have removed all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Souvikns there are still linter errors about cognitive complexity. Ignore them the way I wrote in my previous comment.
we need "lint": "eslint --max-warnings 5 --config .eslintrc .",
to change to "lint": "eslint --max-warnings 0 --config .eslintrc .",
I have removed the warnings but for some reason, I am getting new code smells, Will be fixing them soon. |
I guess I need @magicmatatjahu and @jotamusik approval to merge |
@Souvikns at least @magicmatatjahu as he "requested changes" initially and we can't merge before he accepts |
Yeah, I made the changes @magicmatatjahu requested, I have removed the Let me show how the help message is looking right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@jotamusik waiting from your review |
@Souvikns just fyi you do not need a review of every CODEOWNER, this is needed only when we want to add someone to CODEOWNER file. Imho if you have the approval of 2 maintainers here, you are good to go, unless you synced with Jorge and he needs to have a look. btw tests are failing, please have a look |
ok @derberg I will merge this after I fix the test, They were working before, but when I updated the branch they are failing. |
🎉 This PR is included in version 0.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Add the reverted changes from #124