-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tool file corrected #112
Conversation
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
This PR doesn't introduce a one property rename to simply align it's name with the existing schema like PR #109.
raised several questions:
?
(due to holiday season, answers might delay up to after ~Jan 10, 2023) |
@aeworxet The |
Even if there was a decision made, but change was forgotten to be introduced into the schema, the https://github.com/asyncapi/website/blob/master/scripts/tools/tools-schema.json currently still reads in the description of the
so I have to hit the brakes on this PR until senior engineers come to any agreement. |
@akshatnema @aeworxet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
language
is for people to know if they can integrate it in their code or not
Should the description https://github.com/asyncapi/website/blob/master/scripts/tools/tools-schema.json be altered then? Made more clear maybe? |
/rtm |
🎉 This PR is included in version 0.3.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@akshatnema Next time please use |
Description
The .asyncapi-tool file is corrected according to the errors made while validating with the schema.