feat: add web-component #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me - I'll be more than happy to check the README again as a user when switching from our custom build. |
derberg
requested changes
Nov 6, 2020
There was a problem hiding this comment.
LGTM
just 2 things:
- it should be published to
@asyncapi/web-component - can we rename
async-api-web-component.jstoasyncapi-web-component.jsand any otherasync-apioccurances too? - you need to have this https://github.com/asyncapi/html-template/blob/master/package.json#L28-L30 in package.json of webcomponent otherwise first publishing to npm will fail
|
Kudos, SonarCloud Quality Gate passed!
|
|
@derberg I propagated your suggestions to PR :) |
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Improve web component to be production ready:
web-componentfolder,Related issue(s)
See also #148
@gexclaude if you would like to, I invite you to check the PR, especially the changes in readme :)