fix: bump dependencies to resolve security issues #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
added
the
dependencies
derberg
reviewed
Oct 13, 2020
.github/workflows/release.yml
Outdated
| @@ -37,6 +37,11 @@ jobs: | |||
| GIT_COMMITTER_NAME: asyncapi-bot | |||
| GIT_COMMITTER_EMAIL: info@asyncapi.io | |||
| run: npm run release | |||
| # Sleep for 10 seconds before using latest version in playground, because sometimes NPM needs additional few seconds to `save` package in registry | |||
| - name: Sleep for 10 seconds | |||
| uses: jakejarvis/wait-action@master | |||
There was a problem hiding this comment.
please use something different, this action looks nifty but as you can see it is always fetched from master 😱 which is super unsecure. Unfortunately the user doesn't seem to provide regular professional releases
why not just sleep 30s && npm install @kyma-project/asyncapi-react@${{ steps.extractver.outputs.version }} -s in the playground step?
There was a problem hiding this comment.
Yes, you are right, I changed it to sleep 10 && ...
|
Kudos, SonarCloud Quality Gate passed!
|
derberg
approved these changes
Oct 13, 2020
|
🎉 This PR is included in version 0.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #168