-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: error boundary in layout to handle application errors / crashes #1108
feat: error boundary in layout to handle application errors / crashes #1108
Conversation
…i-react into ErrorBoundary-in-layout
In Firefox:In Chrome:The Error Boundary is detecting the error being generated by the browser on too much recursion and rendering the Error component. Used this asyncapi document for testing asyncapi: 3.0.0
info:
title: Account Service
version: 1.0.0
description: This service is in charge of processing user signups
channels:
userSignedup:
address: user/signedup
messages:
UserSignedUp:
$ref: '#/components/messages/UserSignedUp'
x-recursion: #RECURSION here
$ref: '#'
operations:
sendUserSignedup:
action: send
channel:
$ref: '#/channels/userSignedup'
messages:
- $ref: '#/channels/userSignedup/messages/UserSignedUp'
x-recursion: #RECURSION here
$ref: '#'
components:
messages:
UserSignedUp:
x-recursion: #RECURSION here
$ref: '#'
payload:
type: object
properties:
x-recursion: #RECURSION here
$ref: '#'
displayName:
type: string
description: Name of the user
email:
type: string |
@reachaadrika could you please review this pull request too when you get a chance? 😄 Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome improvement, but i noticed when i fix the recursive properties in the schema, the error still persists in the UI until i either refresh or re-paste a valid schema 🤔
Thanks for highlighting that. Have put some logic to rerender the component fresh. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/rtm |
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
As proposed and discussed here #1101 (comment).
Changes proposed in this pull request:
Added an error boundary in layout to handle errors generated by infinite recursion and such so that the application doesnt crash into an irrecoverable state.
Reused the already existing Error component to render error,
Related issue(s)
#1100