Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding good first issue label do not work as expected #169

Closed
derberg opened this issue May 30, 2022 · 2 comments · Fixed by #188
Closed

adding good first issue label do not work as expected #169

derberg opened this issue May 30, 2022 · 2 comments · Fixed by #188
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bug Something isn't working good first issue Good for newcomers Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com

Comments

@derberg
Copy link
Member

derberg commented May 30, 2022

I added a comment like asyncapi/website#809 (comment) and expected good first issue and area/javascript labels to be added,

Looking quickly at https://github.com/asyncapi/.github/blob/master/.github/workflows/add-good-first-issue-labels.yml#L25-L33 the issue is related to lack of break after each switch case. So just add break after line 30 and 32

@derberg derberg added the bug Something isn't working label May 30, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Sep 28, 2022
@derberg derberg removed the stale label Oct 3, 2022
@derberg
Copy link
Member Author

derberg commented Oct 3, 2022

/gfi js

@asyncapi-bot asyncapi-bot added area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Oct 3, 2022
@derberg derberg added area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. and removed area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Oct 3, 2022
@derberg derberg added the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/javascript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bug Something isn't working good first issue Good for newcomers Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants