Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl Clone for DirEntry #669

Closed
lunacookies opened this issue Jan 13, 2020 · 3 comments · Fixed by #682
Closed

impl Clone for DirEntry #669

lunacookies opened this issue Jan 13, 2020 · 3 comments · Fixed by #682
Labels
api design Open design questions enhancement New feature or request

Comments

@lunacookies
Copy link

Thanks for async_std :)
@ghost
Copy link

ghost commented Jan 13, 2020

The sync version of DirEntry does not implement Clone, which is the reason why we didn't implement it either:
https://doc.rust-lang.org/nightly/std/fs/struct.DirEntry.html

But I suppose implementing Clone for our DirEntry wouldn't hurt. We can even derive the impl because our DirEntry wraps an Arc<std::fs::DirEntry>.

@lunacookies
Copy link
Author

Sounds good!

@yoshuawuyts yoshuawuyts added api design Open design questions enhancement New feature or request labels Jan 14, 2020
@k-nasa k-nasa mentioned this issue Jan 18, 2020
Merged
@lunacookies
Copy link
Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api design Open design questions enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Clone trait for DirEntry k-nasa/async-std
2 participants
@yoshuawuyts @lunacookies