Improve rosout logging #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rosout during init
icolwell-as
requested review from
shan-as,
dvangeyn-as,
jilinzhouas and
kmushty-as
jilinzhouas
reviewed
Nov 26, 2021
| std::string accessModeToString(VmbAccessModeType modeType) { | ||
| std::string s; | ||
| if (modeType & VmbAccessModeFull) | ||
| s = std::string("Read and write access"); |
There was a problem hiding this comment.
How about return \"Read and write access\" so it matches interfaceToString function?
There was a problem hiding this comment.
Sounds good! this function was just moved from another file, I'll improve it though.
jilinzhouas
reviewed
Nov 26, 2021
| CameraPtrVector cameras; | ||
| if (VmbErrorSuccess == vs.Startup()) { | ||
| if (VmbErrorSuccess == vs.GetCameras(cameras)) { | ||
| for (CameraPtrVector::iterator iter = cameras.begin(); |
There was a problem hiding this comment.
how about for (const auto& camera : cameras)?
jilinzhouas
reviewed
Nov 26, 2021
| @@ -142,7 +141,7 @@ class AvtVimbaCamera { | |||
| std::string trigger_source_; | |||
| int trigger_source_int_; | |||
|
|
|||
| CameraPtr openCamera(std::string id_str); | |||
| CameraPtr openCamera(std::string id_str, bool print_all_features); | |||
|
Much cleaner to read now. Appreciate that. |
dvangeyn-as
approved these changes
Nov 26, 2021
jilinzhouas
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #38 by improving the rosout logging.