Trigger over Ethernet #39
Conversation
icolwell-as
requested review from
shan-as,
dvangeyn-as,
jilinzhouas and
kmushty-as
src/avt_vimba_camera.cpp
Outdated
| @@ -342,9 +346,6 @@ CameraPtr AvtVimbaCamera::openCamera(std::string id_str) { | |||
| } | |||
| } | |||
|
|
|||
| // set previous handler back | |||
There was a problem hiding this comment.
why this is removed?
The signal() function defines the handling of the next received signal only, after which the default handling is reinstated. So it is necessary for the signal handler to call signal() if the program needs to continue handling signals using a non-default handler.
There was a problem hiding this comment.
Nice catch, this change is unintentional, I pulled in commits from PR #21 which must have changed this since the PR was based off of an old version of master.
I'll fix.
src/trigger.cpp
Outdated
|
|
||
| Trigger::Trigger() : vimba_system_(AVT::VmbAPI::VimbaSystem::GetInstance()), pnh_("~") | ||
| { | ||
| vimba_system_.Startup(); |
There was a problem hiding this comment.
Does the Startup() call return a true or false?
There was a problem hiding this comment.
Looks like it does, I'll add a return value check.
There was a problem hiding this comment.
If that is case, call it inside the Init() function instead of the constructor.
Resolves #25 by building off of the example left by PR #21
This PR adds a node for enabling ethernet-based triggers. The node will send vimba "actions" (triggers) to the camera based on a repeating timer or based on a subscriber being called.
The Vimba "action" functionality has also been added to the camera configs to allow the ROS driver to configure the camera to be ready to accept action commands.
Tested on Mako G-319