Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies cycle with Astropy to run tests #21

Open
Hellseher opened this issue Dec 2, 2023 · 4 comments
Open

Dependencies cycle with Astropy to run tests #21

Hellseher opened this issue Dec 2, 2023 · 4 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file 🔥 Critical

Comments

@Hellseher
Copy link

Hellseher commented Dec 2, 2023

I've faced with this issue during preparing this project for Guix when update Astropy to 6.0.0 requires it as external package.

According to tox.ini requires astropy itself to run tests:

This project:

deps =
git+https://github.com/astropy/astropy
extras =
test
commands =
pip freeze
pytest --pyargs astropy.coordinates -m "not hypothesis" {posargs}
pytest --pyargs astropy.time -m "not hypothesis" {posargs}
pytest --pyargs astropy.utils.iers -m "not hypothesis" {posargs}

Astropy project:
https://github.com/astropy/astropy/blob/9ce2087bd81f9502c4fdb87168d1cccd1aee4f53/pyproject.toml#L41-L47

Is there any other way to test the project without astropy?

Thanks.
Oleg

@pllim
Copy link
Member

pllim commented Dec 2, 2023

This package is meant to be used by astropy. Why would you want to test this package without astropy?

You should install both first before testing any of them.

@pllim pllim added the question Further information is requested label Dec 2, 2023
@astrofrog
Copy link
Member

We could certainly include some basic tests here that aren't astropy-dependent.

@Hellseher
Copy link
Author

Hellseher commented Dec 3, 2023

Hi,

Thank you for your replay.

The issue is that each package is built separately in isolated environment to
provide 100% reproducibility, one of the phase is to run unit tests:

to test astropy-iers-data -> install astropy -> install astropy-iers-data -> to test astropy-iers-data -> to head...

@astrofrog Any unit tests which do no require astropy would be great. To run tests of astropy would have no issues.

@pllim
Copy link
Member

pllim commented Sep 9, 2024

@astrofrog , we need to figure this out quick because job is failing now that prevents data update. See #27 for more details. Thanks!

@pllim pllim added bug Something isn't working dependencies Pull requests that update a dependency file 🔥 Critical and removed question Further information is requested labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file 🔥 Critical
Projects
None yet
Development

No branches or pull requests

3 participants