Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

build_docs success checking is not working on Windows #271

Closed
bsipocz opened this issue Dec 3, 2016 · 1 comment · Fixed by #267
Closed

build_docs success checking is not working on Windows #271

bsipocz opened this issue Dec 3, 2016 · 1 comment · Fixed by #267
Labels

Comments

@bsipocz
Copy link
Member

bsipocz commented Dec 3, 2016

The appveyor builds are now failing to notice the "build succeeded." line in the sphinx output.
The check was introduced in #223, but at the time the appveyor build was not working due to an unrelated graphiz issue.

See: https://ci.appveyor.com/project/Astropy/astropy-helpers/build/1.0.434/job/umdl56aw8a60po29

@bsipocz bsipocz added the bug label Dec 3, 2016
@bsipocz
Copy link
Member Author

bsipocz commented Dec 3, 2016

The bug is related to the line ending in windows, we either need a conditional for line 190 which is a bit hacky, or doing something more hacky a bit further down. I'll add the fix to the PR #267.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant