Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make read_parquet_dataset() less I/O intense #161

Closed
hombit opened this issue Nov 7, 2023 · 0 comments · Fixed by #164
Closed

Make read_parquet_dataset() less I/O intense #161

hombit opened this issue Nov 7, 2023 · 0 comments · Fixed by #164
Assignees

Comments

@hombit
Copy link
Contributor

hombit commented Nov 7, 2023

Currently hipscat.io.file_io.read_parquet_dataset() makes some assumptions which could be suboptimal for some use-cases. For instance, it sets pyarrow.dataset.dataset(exclude_invalid_files=True) which force-scan the whole catalog. I propose to make this behavior optional.

This change would also require updating ignore_prefixes, which currently doesn't include JSON and FITS metadata files, which makes pyarrow.dataset.datase believe that they are parquet files. Probably, we could also allow user to provide custom ignore_prefixes.

The probable solution would be adding **kwargs to the function and allow to pass any arguments to pyarrow.dataset.dataset arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants