Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify venv parameter to use dbt executable path instead of venv #82

Closed
chrishronek opened this issue Jan 10, 2023 · 0 comments · Fixed by #83
Closed

Modify venv parameter to use dbt executable path instead of venv #82

chrishronek opened this issue Jan 10, 2023 · 0 comments · Fixed by #83
Assignees
Labels
enhancement New feature or request

Comments

@chrishronek
Copy link
Contributor

chrishronek commented Jan 10, 2023

Currently, we are sourcing the venv here. Instead, we should reference the dbt executable so that implementing the dbt-ol wrapper is easier.

Before:

dbt_path = [bash_path, "-c", f"source {self.python_venv} && dbt {self.base_cmd} "]

After:

{self.python_venv}/bin/dbt {self.base_cmd}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant