Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use single serialization format for all block state data #1434

Open
Fraser999 opened this issue Aug 30, 2024 · 1 comment · May be fixed by #1492
Open

Use single serialization format for all block state data #1434

Fraser999 opened this issue Aug 30, 2024 · 1 comment · May be fixed by #1492
Assignees
@Fraser999

Comments

@Fraser999
Copy link
Contributor

Fraser999 commented Aug 30, 2024 •
edited
Loading

Format to use will be decided once #1433 is completed and discussed.

Every type of data to be encoded should have a separate type in a new storage module, and potentially we should have an enum of all these types, with an instance of the enum being what is actually encoded and stored to disk (although this is not agreed upon at the moment).

┆Issue Number: ENG-768
@Fraser999 Fraser999 self-assigned this Aug 30, 2024
@Fraser999
Copy link
Contributor Author

Decision made in favour of Borsh after discussion of this benchmarking repo.

@Fraser999 Fraser999 linked a pull request Sep 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fraser999 Fraser999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(sequencer)!: exclusively use Borsh encoding for stored data (ENG-768) astriaorg/astria
1 participant
@Fraser999