Add support for --with-editable to uv tool ru
#6744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Aug 28, 2024
crates/uv/tests/tool_run.rs
Outdated
Comment on lines
942
to
950
| // If invalid, we should reference `--with`. | ||
| uv_snapshot!(context.filters(), context.tool_run().arg("--with").arg("./foo").arg("flask").arg("--version"), @r###" | ||
| success: false | ||
| exit_code: 2 | ||
| ----- stdout ----- | ||
|
|
||
| ----- stderr ----- | ||
| error: Distribution not found at: file://[TEMP_DIR]/foo | ||
| "###); |
There was a problem hiding this comment.
Just a quick comment, looks like this doesn't reference --with like we'd hope :)
There was a problem hiding this comment.
Thank you for your review :)
I'll try working on it for a few more days 👍🏽
There was a problem hiding this comment.
I've implemented the feature similarly to the pull request, but I'm running into an issue where an anyhow::Error is being returned, which is preventing me from adding context to the error. I need to investigate this further, but if you have any insights or know of a possible cause, I would greatly appreciate your input.
There was a problem hiding this comment.
@zanieb
Could you please check it once?
kyoto7250
force-pushed
the
add_with_editable_in_uvx
branch
from
b6a3cd2
to
cca6718
Compare
|
Sorry for the delay! It's been a busy few weeks. I'll get to this soon. |
zanieb
changed the title
--with-editable to uv tool
zanieb
approved these changes
Sep 17, 2024
zanieb
changed the title
--with-editable to uv tool--with-editable to uv tool ru
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #6272
Test Plan
As in #6262