Skip to content

Commit 2598292

Browse files
authoredJan 20, 2025
Include version and contact information in GitHub User Agent (#10785)
## Summary See: #10765 (comment)
1 parent 5ee4cf6 commit 2598292

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed
 

‎Cargo.lock

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎crates/uv-git/Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ uv-cache-key = { workspace = true }
2020
uv-fs = { workspace = true, features = ["tokio"] }
2121
uv-auth = { workspace = true }
2222
uv-static = { workspace = true}
23+
uv-version = { workspace = true }
2324

2425
anyhow = { workspace = true }
2526
cargo-util = { workspace = true }

‎crates/uv-git/src/git.rs

+5-1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ use url::Url;
1616

1717
use uv_fs::Simplified;
1818
use uv_static::EnvVars;
19+
use uv_version::version;
1920

2021
use crate::sha::GitOid;
2122
use crate::{GitHubRepository, GitSha};
@@ -782,7 +783,10 @@ fn github_fast_path(
782783
debug!("Attempting GitHub fast path for: {url}");
783784
let mut request = client.get(&url);
784785
request = request.header("Accept", "application/vnd.github.3.sha");
785-
request = request.header("User-Agent", "uv");
786+
request = request.header(
787+
"User-Agent",
788+
format!("uv/{} (+https://github.com/astral-sh/uv)", version()),
789+
);
786790
if let Some(local_object) = local_object {
787791
request = request.header("If-None-Match", local_object.to_string());
788792
}

‎crates/uv-git/src/resolver.rs

+6-3
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ use std::sync::Arc;
55

66
use tracing::debug;
77

8+
use crate::{Fetch, GitHubRepository, GitReference, GitSha, GitSource, GitUrl, Reporter};
89
use dashmap::mapref::one::Ref;
910
use dashmap::DashMap;
1011
use fs_err::tokio as fs;
1112
use reqwest_middleware::ClientWithMiddleware;
1213
use uv_cache_key::{cache_digest, RepositoryUrl};
1314
use uv_fs::LockedFile;
14-
15-
use crate::{Fetch, GitHubRepository, GitReference, GitSha, GitSource, GitUrl, Reporter};
15+
use uv_version::version;
1616

1717
#[derive(Debug, thiserror::Error)]
1818
pub enum GitResolverError {
@@ -73,7 +73,10 @@ impl GitResolver {
7373
debug!("Attempting GitHub fast path for: {url}");
7474
let mut request = client.get(&url);
7575
request = request.header("Accept", "application/vnd.github.3.sha");
76-
request = request.header("User-Agent", "uv");
76+
request = request.header(
77+
"User-Agent",
78+
format!("uv/{} (+https://github.com/astral-sh/uv)", version()),
79+
);
7780

7881
let response = request.send().await?;
7982
if !response.status().is_success() {

0 commit comments

Comments
 (0)