Formatter undocumented deviation: Redundant parentheses in boolean expression can lead to extra line breaks

[henribru]

Black:

def foo():
    while (
        not (aaaaaaaaaaaaaaaaaaaaa(bbbbbbbb, ccccccc)) and dddddddddd < eeeeeeeeeeeeeee
    ):
        pass

Ruff:

def foo():
    while not (
        aaaaaaaaaaaaaaaaaaaaa(bbbbbbbb, ccccccc)
    ) and dddddddddd < eeeeeeeeeeeeeee:
        pass

[MichaReiser]

Could this be related/due to #8100?

[MichaReiser]

I think the issue here is that we set first in CanOmitOptionalParenthesesVisitor to the UnaryExpr.value instead of the unary expression itself. I think we have the same problem for other nodes that start with a token (if expression, dict etc)

[MichaReiser]

Okay I think I understand it now... It is an issue with can_omit_parentheses. Black uses different rules to test if the first or last node have parentheses.

• first: Needs to start with parentheses. That excludes call expressions.
• last: Needs to end with parentheses. Call, lists, etc