F523 should not be marked as always-fixable

[addisoncrump]

It is possible to split a format invocation across multiple lines:

(''
.format(2))

This makes ruff a bit mad:

error: Failed to create fix for StringDotFormatExtraPositionalArguments: Failed to extract expression from source
fuzz/artifacts/ruff_fix_validity/minimized-from-f670b0a6b2f154ee6d66e9ad4f601cab0b3d4609:1:2: F523 `.format` call has unused arguments at position(s): 0
Found 1 error.

Discovered by #4822.

[charliermarsh]

I believe this is a known issue in LibCST (that we filed): Instagram/LibCST#846. Going to close since we're mostly just waiting for it to be resolved upstream.

[addisoncrump]

Hm, okay. I will need to filter out this particular case in the fuzzers (to prevent the panic induced in code I didn't write 😅).

[charliermarsh]

Gahhh haha sorry! That error is caught and handled, right? It doesn't actually panic, does it? It's supposed to be handled and logged to the user.

[addisoncrump]

Yes, but when using the test suite functions, this panics (it is marked as always-fixable).

[charliermarsh]

Oh, we should change it to "sometimes".

[addisoncrump]

So, should we reopen with different title?

[charliermarsh]

I'll just fix it real quick.