UP035 --fix not working for Deque

[torarvid]

When running ruff --fix test.py (Ruff 0.0.255), it doesn't change the Deque to deque

from typing import Deque

a: Deque[str]

However, interestingly, if we replace Deque with List, it does change to list

from typing import List

a: List[str]

[JonathanPlasse]

• deque is not a builtin like list. deque need to be imported. Currently, it is not possible to auto-fix. We first need Add the possibility to add import and respect the import sorting. #835.

[charliermarsh]

Yeah we can't fix this right now -- but, in theory, we should be able to.

[torarvid]

Ah, I didn't know about #835, but I understand this issue depends on that. Thanks for the info 👍🏻

[tmke8]

This is the full list of typing imports that can be rewritten on Python 3.9:

• collections.deque # typing.Deque
• collections.defaultdict # typing.DefaultDict
• collections.OrderedDict
• collections.Counter
• collections.ChainMap
• collections.abc.Awaitable
• collections.abc.Coroutine
• collections.abc.AsyncIterable
• collections.abc.AsyncIterator
• collections.abc.AsyncGenerator
• collections.abc.Iterable
• collections.abc.Iterator
• collections.abc.Generator
• collections.abc.Reversible
• collections.abc.Container
• collections.abc.Collection
• collections.abc.Callable
• collections.abc.Set # typing.AbstractSet
• collections.abc.MutableSet
• collections.abc.Mapping
• collections.abc.MutableMapping
• collections.abc.Sequence
• collections.abc.MutableSequence
• collections.abc.ByteString
• collections.abc.MappingView
• collections.abc.KeysView
• collections.abc.ItemsView
• collections.abc.ValuesView
• contextlib.AbstractContextManager # typing.ContextManager
• contextlib.AbstractAsyncContextManager # typing.AsyncContextManager
• re.Pattern # typing.Pattern, typing.re.Pattern
• re.Match # typing.Match, typing.re.Match

source: https://peps.python.org/pep-0585/#implementation

[charliermarsh]

The rewrites that don't require renames are already handled by UP035 (e.g., importing from collections import Counter instead of from typing import Counter).