SIM108 not raised for instance variables

[cspoelstra]

Summary

SIM108 is not being raised for instance variables.

class A:
    def func(self):
        if cond:
            self.x = a
        else:
            self.x = b

Expected behavior:
SIM108 raised to suggest

self.x = a if cond else b

Actual behavior:
SIM108 not raised.

Removing self. causes the rule to be raised.

[ntBre]

Thanks for the report! It looks like the rule is currently restricted to simple variable name expressions like the upstream rule, but I think it makes sense to expand it to attribute accesses (as in this example) and probably subscripts too. I think that should cover valid left-hand sides of assignments.

ruff/crates/ruff_linter/src/rules/flake8_simplify/rules/if_else_block_instead_of_if_exp.rs

Lines 128 to 133 in b3c884f

	let Expr::Name(ast::ExprName { id: body_id, .. }) = body_target else {
	return;
	};
	let Expr::Name(ast::ExprName { id: else_id, .. }) = else_target else {
	return;
	};

[MichaReiser]

The challenge with allowing more expressions is that we then get pushback that the resulting expression is now too complicated and isn't a simplification. That's why, for now, I'd prefer to keep the rule aligned with the upstream rule.