Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design display of fixes in check when there is no source #12600

Open
chriskrycho opened this issue Jul 31, 2024 · 0 comments
Open

Design display of fixes in check when there is no source #12600

chriskrycho opened this issue Jul 31, 2024 · 0 comments
Labels
cli Related to the command-line interface diagnostics Related to reporting of diagnostics. fixes Related to suggested fixes for violations

Comments

@chriskrycho
Copy link
Contributor

Spun off from #12595: in some cases, there may be a possible fix but no source, e.g. when passing no input at all (see here from an earlier version of the PR than the one that landed). Most likely, those fixes should not be emitted at all. However, this needs a bit of design: maybe it is legitimate in some cases; and/or perhaps the decision should happen upstream to avoid creating the fix at all?

@AlexWaygood AlexWaygood added the fixes Related to suggested fixes for violations label Jul 31, 2024
@dhruvmanila dhruvmanila added the cli Related to the command-line interface label Aug 1, 2024
@MichaReiser MichaReiser added the diagnostics Related to reporting of diagnostics. label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command-line interface diagnostics Related to reporting of diagnostics. fixes Related to suggested fixes for violations
Projects
None yet
Development

No branches or pull requests

4 participants